Stamps Issue
-
Hi, I have 931 stamp files, but only 25 pages load. This seems to be a limit put in to prevent issues.
This is particularly annoying as i have rescanned, and have seemingly "lost" some stamps related to old builds ect that i wish to retrieve
Is there any way to modify this limit?
EDIT1:Can confirm this is a limiting issue, manually modified stamps file to include some 2017 stamps, magically appeared.
Edited once by ToxicI11I. Last: 30th Sep 2018 -
I don't see any reference to a 25 page limit in the code. (I checked the stamp adding code, the rescanning code, and the stamp browser gui code). Are you sure about that? If you create one more stamp, are you getting limited?
Rescan stamps should always work, and I would expect it to create 47 pages. I wonder if some of them are invalid? Usually it tells you though and lets you delete invalid stamps.
You mentioned you edited stamps.def, were you also renaming stamps? Stamps are forced to be 10 characters at the moment. -
Hey jacob, I have not renamed any stamps, a few are from a couple of versions back, but no. And if i do create a new stamp, it does seem to still be stuck at 25. Ill give it a few more goes and let you know.
(even when manually adding 931 stamp files to it, it only loads 25 pages*)
Edit2:Whenever i create a new stamp it deloads the oldest one(least used one), keeping it limited at 25 pages.
Edited 2 times by ToxicI11I. Last: 30th Sep 2018 -
@ToxicI11I (View Post)
Oh, are you using the Android port or my mod? Those are based on the original codebase. Apparently the stamp code in those is so old that there is a 25 page limit ... I need to rewrite the stamp code. -
Im using your mod, which includes the script manager ect.
-
@ToxicI11I (View Post)
Ok. So I guess this is a bug I didn't know about because I only have 5 pages of stamps and haven't looked at the stamp code in a long time. I opened an issue on github to remind me to fix it.
Not sure when I'll get around to it. I might try to do a new version of my mod soon with other changes. Then maybe the version after that I'll fix it? No guarantees, I haven't done too much development recently.
I've been wanting to rewrite the stamp browser for a while now though.
