Suggestion: Rechargeable battery

  • wolfy1339
    12th Jun 2013 Member 0 Permalink

    i would like to see a rechargeable battery in a future version of tpt.

    And since the code is already finished for it, i might actualy get higher chances that you guys include it in tpt.

    Code for RBTY:https://www.dropbox.com/s/gwxokcpg43gxhtc/RBTY.cpp

    I know this has been suggested already.... but i am just trying and since the code is already done....

  • xetalim
    12th Jun 2013 Member 0 Permalink

    <post removed>?

  • mniip
    12th Jun 2013 Developer 0 Permalink
    do you realize this violates the GPL license
  • jacob1
    12th Jun 2013 Developer 0 Permalink
    I think you are going to have to explain why it does, you can't just say "this violates GPL"

    Although I sort of know why. I didn't accept the pull request xetalim made because it was your code, which was mniip's code, so it didn't have the right credit and noone ever asked him if he wanted it in.
  • cyberdragon
    12th Jun 2013 Member 0 Permalink

    There's some issues with that code. Specifically that it can be charged and discharged at the same time. For example:

     

    pscn    rbty    metl 

     

    would make it unable to charge at all and it would just act as a passive conductor. You need to have it not able to discharge while being charged.

     

    EDIT: It will charge in that situation, but slower and it does discharge at the same time.

  • wolfy1339
    13th Jun 2013 Member 0 Permalink

    @cyberdragon (View Post)

     ok. will message you about that.

     

    And @jacob1

    LOCK!LOCK!LOCKITY!LOCK!

Locked by jacob1: lock requested