Favorites Tab Not Working

  • Wazabi-Bros
    15th Nov 2012 Member 0 Permalink

    Thanks Jacob for that! Your help is appreciated!

     EDIT: Found the problem... only to find another problem... user's banned. Suggestions?

  • EqualsThree
    15th Nov 2012 Member 0 Permalink

    @jacob1 (View Post)

    What was dividing by 0?

     

  • jacob1
    15th Nov 2012 Developer 0 Permalink
    @Wazabi-Bros (View Post)
    the user being banned is the reason the save doesn't have an auto-upvote. Just vote on the save, and that should fix it.

    @EqualsThree (View Post)
    it finds whether there are upvotes or more downvotes, and then takes the max of that. Normally, every save has at least one vote, so it can never get 0. Later, it divides by this number. As long as there is either 1 up or 1 downvote, it will divide by that instead.

    Edit: Simon fixed it himself.... I don't think he ever checks my github repository then (this is for the next version)
  • Simon
    15th Nov 2012 Administrator 0 Permalink
    @jacob1 (View Post)
    I don't have access to the git tools so I just merged it on github.
  • jacob1
    15th Nov 2012 Developer 0 Permalink
    @Simon (View Post)
    oh, ok. I didn't know you could do that from inside github (unless you mean directly edit the file probably)... can you also merge this commit fixing tpt.el.X.name and do the thing I did in this crash fix? (but replace delete this; with SelfDestruct();, I think you said that was needed instead).

    Also, something like this allows mod makers to remove the update notification easily.
  • Wazabi-Bros
    16th Nov 2012 Member 0 Permalink

    The problem is though, I can't open the save :/